OR and AND conditions bug

[ratchet]

Example code:
[scar]program test;
function test(): boolean;
begin
     writeln('Do not go here');
     result:= true;
end;
begin
     if (true or test()) then writeln('true or true');
     if (false and test()) then writeln('false and true');
end.[/scar]

The test() is executed in both cases, although the IF branches correctly. The condition checking should no longer be necessary after the first true OR and false AND.

Implementing this change will also optimise the performance as long chains of conditionals will no longer have to all be checked before branching.

Optimizations within the code by having the most common tested first will also work.

[nielsie95]

Short circuit boolean evaluation is currently not supported by SCAR. You're right about that it will be faster and easier, but it's not a bug

[ratchet]

Is that a way of saying that this won't be fixed?

[Freddy]

Is that a way of saying that this won't be fixed?

Pretty much... You have to contact the author of the script engine SCAR uses to request this feature... But the author has expressed that he does not wish to add many more new features because some features are nearly impossible to add due to the way the engine is constructed... http://www.remobjects.com/ps.aspx

[ratchet]

I had a peek at the Pascal script for Delphi source, and it looks like it is already there.

It looks like it is set as a property of the compiler class, I'm pretty sure your dephi is better than mine but hopefull this helps to get it going.

In file uPSCompiler.pas (line: 1181):

Code: [Select]

    property BooleanShortCircuit: Boolean read FBooleanShortCircuit write FBooleanShortCircuit;

[Freddy]

I had a peek at the Pascal script for Delphi source, and it looks like it is already there.

It looks like it is set as a property of the compiler class, I'm pretty sure your dephi is better than mine but hopefull this helps to get it going.

In file uPSCompiler.pas (line: 1181):

Code: [Select]

    property BooleanShortCircuit: Boolean read FBooleanShortCircuit write FBooleanShortCircuit;

Wtf, it's in there and not enabled by default? It shouldn't even be an option, it should be in there by default, that's just retarded... Well, I'll enable it in the next SCAR release...

Fixed for 3.25